RFR: JDK-8267930: Refine code for loading hsdis library [v5]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Tue Jun 1 12:27:20 UTC 2021
On Tue, 1 Jun 2021 07:40:38 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> code for loading hsdis library is redundant, this is to simplify it.
>
> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>
> - reorder arguments
> - reorder arguments
src/hotspot/share/compiler/disassembler.cpp line 818:
> 816: if (jvm_offset >= 0) {
> 817: // 1. <home>/lib/<vm>/libhsdis-<arch>.so
> 818: _library = dll_load(buf, jvm_offset, sizeof buf, ebuf, sizeof ebuf, st);
All of `dll_load()` are called with incorrect arguments order - length is should be just after offset.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4260
More information about the hotspot-compiler-dev
mailing list