RFR: 8268052: [JVMCI] non-default installed code must be marked as in_use

Tom Rodriguez never at openjdk.java.net
Tue Jun 1 15:59:36 UTC 2021


On Tue, 1 Jun 2021 15:52:22 GMT, Tom Rodriguez <never at openjdk.org> wrote:

> 8268052: [JVMCI] non-default installed code must be marked as in_use

src/hotspot/share/jvmci/jvmciRuntime.cpp line 1789:

> 1787:               method->set_code(method, nm);
> 1788:             } else {
> 1789:               result = JVMCI::nmethod_reclaimed;

Is it really possible for the make_in_use call to fail if the nmethod is nmethodLocker'ed?  The copy of this logic in ciEnv.cpp doesn't treat a failure of this call to be a compilation failure but it certainly seems like it should.  It would be better if it weren't possible for this call to fail.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4283


More information about the hotspot-compiler-dev mailing list