RFR: 8268125: ZGC: Clone oop array gets wrong acopy stub

Vladimir Kozlov kvn at openjdk.java.net
Fri Jun 4 20:31:59 UTC 2021


On Fri, 4 Jun 2021 11:43:26 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

> Hi,
> 
> This fixes a problem I introduced with JDK-8267726. With that change clone oop array is treated as normal clone arrays with ZGC. I missed that a case was missing in zBarrierSetC2::clone_at_expansion - which caused clone_oop-arrays to get the wrong array copy stub.
> 
> In this fix I move the entire leaf call creation inside zBarrierSetC2, and leave BarrierSetC2 as is. In this way I don't have to change anything for the other collectors.
> 
> Please review,
> Best regards,
> Nils Eliasson

Update copyright years in files.

test/hotspot/jtreg/compiler/arraycopy/TestObjectArrayClone.java line 33:

> 31:  *                   compiler.arraycopy.TestObjectArrayClone
> 32:  *
> 33:  * @run main/othervm -XX:+IgnoreUnrecognizedVMOptions -XX:+UseZGC

I suggest to clone it to separate `@test` block because you need `@requires  vm.gc.Z` for it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4359


More information about the hotspot-compiler-dev mailing list