RFR: 8267663: [vector] Add unsigned comparison operators on AArch64 [v2]
Eric Liu
eliu at openjdk.java.net
Mon Jun 7 09:46:23 UTC 2021
On Sat, 5 Jun 2021 08:04:07 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/aarch64_neon_ad.m4 line 889:
>>
>>> 887:
>>> 888: static void neon_compare(C2_MacroAssembler masm, FloatRegister dst, BasicType bt,
>>> 889: FloatRegister src1, FloatRegister src2, int cond, bool isX) {
>>
>> Passing masm by value, rather than reference, is unconventional. There's no reason to do that.
>
> Come to think about it, why isn't this an Assembler method?
The latest fix moves it into macroAssembler, it's more reasonable.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4358
More information about the hotspot-compiler-dev
mailing list