RFR: 8267663: [vector] Add unsigned comparison operators on AArch64 [v2]

Andrew Haley aph at openjdk.java.net
Mon Jun 7 10:35:00 UTC 2021


On Mon, 7 Jun 2021 10:10:32 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Eric Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor code
>>   
>>   - public elemBytes_to_Arrangement and make it more generalized since it
>>     maybe useful in the future.
>>   - move neon_compare into macroAssembler.
>>   
>>   Change-Id: I7596de03abb066574cf430d935edd07cd627e14b
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5373:
> 
>> 5371:       case BoolTest::gt: fcmgt(dst, size, src1, src2); break;
>> 5372:       case BoolTest::le: fcmge(dst, size, src2, src1); break;
>> 5373:       case BoolTest::lt: fcmgt(dst, size, src2, src1); break;
> 
> Are you sure about these two lines?

Sorry, I see what's happening: the operands are reversed. This is tricky code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4358


More information about the hotspot-compiler-dev mailing list