RFR: 8268293: VectorAPI cast operation on mask and shuffle is broken [v2]
Paul Sandoz
psandoz at openjdk.java.net
Mon Jun 7 17:50:22 UTC 2021
On Mon, 7 Jun 2021 17:30:42 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Existing implementation of VectoMask.cast and VectorShuffle.cast operation do not generate correct mask compliant with the species passed as the argument.
>>
>> This patch fixes the implementation and adds the corresponding cast operation test cases to VectorAPI regression suite.
>
> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>
> - 8268293: Correcting file permissions.
> - Merge http://github.com/openjdk/jdk into JDK-8268293
> - 8268293: Chaining gen-tests.sh file permissions.
> - 8268293: VectorAPI cast operation on mask and shuffle is broken
Rather than introducing optional tests, can we make them all required and increase the testing scope to also test for an exception? I think that would simplify the test generation logic.
Thus we push the size checks into the test methods. For the case of when an exception is expected we just need to call the cast once.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4392
More information about the hotspot-compiler-dev
mailing list