RFR: 8268293: VectorAPI cast operation on mask and shuffle is broken [v3]

Paul Sandoz psandoz at openjdk.java.net
Tue Jun 8 17:17:19 UTC 2021


On Tue, 8 Jun 2021 17:11:42 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Existing implementation of VectoMask.cast and VectorShuffle.cast operation do not generate correct mask compliant with the species passed as the argument.
>> 
>> This patch fixes the implementation and adds the corresponding  cast operation test cases to VectorAPI regression suite.
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8268293: Review comments resolution.

What concerns me is the additional complexity of the bash script. I would prefer not to increase the complexity and keep it as simple as possible, and place such conditions within Java test code which is more easily maintainable.

In fact i wonder if it makes sense to add such tests to the Vector*ConversionTests?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4392


More information about the hotspot-compiler-dev mailing list