RFR: 8268125: ZGC: Clone oop array gets wrong acopy stub [v4]

[Vladimir Ivanov]

On Mon, 14 Jun 2021 14:17:17 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Hi,
>> 
>> This fixes a problem I introduced with JDK-8267726. With that change clone oop array is treated as normal clone arrays with ZGC. I missed that a case was missing in zBarrierSetC2::clone_at_expansion - which caused clone_oop-arrays to get the wrong array copy stub.
>> 
>> In this fix I move the entire leaf call creation inside zBarrierSetC2, and leave BarrierSetC2 as is. In this way I don't have to change anything for the other collectors.
>> 
>> Please review,
>> Best regards,
>> Nils Eliasson
>
> Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove whitespace

Looks good.

src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp line 257:

> 255: }
> 256: 
> 257: #define XTOP LP64_ONLY(COMMA phase->top())

I'm curious whether `XTOP` should be underfined at the end of the scope (here and in other places).

-------------

Marked as reviewed by vlivanov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4359