[jdk17] RFR: 8266518: Refactor and expand scatter/gather tests

Sandhya Viswanathan sviswanathan at openjdk.java.net
Wed Jun 16 20:57:27 UTC 2021


On Mon, 14 Jun 2021 16:26:17 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

> Refactor scatter/gather tests to be included in the load/store test classes and expand to support access between `ShortVector` and and `char[]`, and access between `ByteVector` and `boolean[]`.
> 
> Vector tests pass on linux-x64 linux-aarch64 macosx-x64, and windows-x64.

Thanks for refactoring and adding new scatter/gather tests for boolean and char. Other than the duplicate data provider in byte/boolean tests, the rest looks good to me.

test/jdk/jdk/incubator/vector/Byte128VectorLoadStoreTests.java line 1248:

> 1246:             toArray(Object[][]::new);
> 1247:     }
> 1248: 

The byteGatherScatterProvider and byteGatherScatterMaskProvider seem to be same as gatherScatterProvider and gatherScatterMaskProvider above.

-------------

Marked as reviewed by sviswanathan (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/48


More information about the hotspot-compiler-dev mailing list