[jdk17] RFR: 8268293: VectorAPI cast operation on mask and shuffle is broken [v5]

[Jatin Bhateja]

On Thu, 17 Jun 2021 18:41:55 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Existing implementation of VectoMask.cast and VectorShuffle.cast operation do not generate correct mask compliant with the species passed as the argument.
>> 
>> This patch fixes the implementation and adds the corresponding cast operation test cases to VectorAPI regression suite.
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8268293: Review comments resolution.

> This is looking much better.
> 
> The data providers don't need to provide a list of illegal and illegal as arguments to the test. Instead, you can have two data providers one providing the array of array of arguments for legal species, and the other for illegal.
> 
> (A data provider returns Object[][] providing the array of arguments. The length of the outer array is the number of tests to run, so the test itself does not need to loop over the test cases.)
> 
> Then, have two corresponding tests, that get supplied with a **single** src and target species like for the other conversion tests.
> 
> Then, tests can call a _kernel_ that performs the looping, again copying the pattern of the existing tests.
> 
> It might be easier to first modify the data providers, then when that is working develop the kernel.

Hi @PaulSandoz , thanks for your suggestions, I have split the data provider and tests, we now have separate +ve and -ve tests, each of which accepts a species and the array of legal/illegal species corresponding to it.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/39