RFR: 8268858: Determine register pressure automatically by the number of available registers for allocation [v2]

Joshua Zhu jzhu at openjdk.java.net
Tue Jun 22 08:04:34 UTC 2021


On Mon, 21 Jun 2021 18:59:02 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Joshua Zhu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comments and place test into proper location
>
> src/hotspot/cpu/aarch64/aarch64.ad line 2562:
> 
>> 2560:   // Lowering the default value to (_NO_SPECIAL_REG32_mask.Size() minus 1)
>> 2561:   // fixes this bug. See JDK-8183543.
>> 2562:   uint int_pressure_threshold = _NO_SPECIAL_REG32_mask.Size() - 1;
> 
> This is not explanation. Comment should explain why with -1 the issue is fixed. (Repeating because it could be hidden in previous conversation)

I add more details in comments. Please let me know if I explain clearly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4505


More information about the hotspot-compiler-dev mailing list