RFR: 8267982: Set the node after peephole optimization to be removed [v2]
SUN Guoyun
github.com+40024232+sunny868 at openjdk.java.net
Wed Jun 23 07:18:52 UTC 2021
On Wed, 23 Jun 2021 06:24:19 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> SUN Guoyun has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>
>> 8267982: Set the node after peephole optimization to be removed
>
> src/hotspot/share/adlc/output_c.cpp line 1346:
>
>> 1344:
>> 1345: for( int i = 0; i <= max_position; i++)
>> 1346: fprintf(fp, " inst%d->set_removed();\n", i);
>
> Code style. Use `{}`:
>
> for () {
> }
Done
> src/hotspot/share/opto/buildOopMap.cpp line 470:
>
>> 468: int second = regalloc->get_reg_second(def);
>> 469: if( OptoReg::is_valid(first) && !def->get_removed()) set_live_bit(tmp_live,first);
>> 470: if( OptoReg::is_valid(second) && !def->get_removed()) set_live_bit(tmp_live,second);
>
> You need `def->as_Mach()->get_removed()` because `def ` is `Node*`.
Done
-------------
PR: https://git.openjdk.java.net/jdk/pull/4276
More information about the hotspot-compiler-dev
mailing list