RFR: 8267982: Set the node after peephole optimization to be removed [v7]

[Vladimir Kozlov]

On Fri, 25 Jun 2021 01:18:27 GMT, SUN Guoyun <github.com+40024232+sunny868 at openjdk.org> wrote:

>> Hi all,
>> 
>> Enable peephole can cause SIGSEGV sometimes in OopFlow::build_oop_map(Node*, int, PhaseRegAlloc*, int*)+0x238 , so must set a removed-flags for the peephole-nodes , to avoid be set-live-bit() and cause crash.
>>  Please review this trivial change.
>> 
>> Thanks,
>> Sun Guoyun
>
> SUN Guoyun has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8267982: Set the node after peephole optimization to be removed

Looks good. I have only style fix comment.
I will test changes meanwhile because I don't see it passed through GitHub testing.

src/hotspot/share/opto/buildOopMap.cpp line 474:

> 472:             if( OptoReg::is_valid(first) ) set_live_bit(tmp_live,first);
> 473:             if( OptoReg::is_valid(second) ) set_live_bit(tmp_live,second);
> 474:           }

Code style. Use next pattern in code you modified (body on separate line and no spaces before/after condition):

if (cond) {
  foo;
}
``` 
We want to correct style in all places eventually as we work on code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4276