RFR: 8269122: The use of "extern const" for Register definitions generates poor code [v3]
Kim Barrett
kbarrett at openjdk.java.net
Fri Jun 25 06:44:07 UTC 2021
On Thu, 24 Jun 2021 07:38:15 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> The old code was a workaround for compilers that don't handle inline constants well. There are ports that I don't know about or can't test, and there are some outside the main jdk/jdk tree. If this change breaks any of them, all they have to do is define USE_EXTERN_CONST_FOR_REGISTER_DEFINITIONS. If it turns out that no such systems still exist, we can take it out.
>
> Are you satisfied with that, Kim? Thanks.
Not really. I don't think we should be retaining dead code to support potential / imaginary compilers. If such a compiler still exists (and is sufficiently modern to support C++14), the relevant code can be retrieved from the repository.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4554
More information about the hotspot-compiler-dev
mailing list