RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 [v2]

Scott Gibbons github.com+6704669+asgibbons at openjdk.java.net
Mon Jun 28 15:23:02 UTC 2021


On Sun, 27 Jun 2021 01:54:41 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Format warning removal.
>
> compiler/intrinsics/base64/TestBase64.java failed with wrong result on Windows (avx512):
> 
> ----------System.out:(1/17)----------
> 5000 iterations
> ----------System.err:(17/1502)----------
> java.lang.RuntimeException: Assertion failed! The result is not same as expected
>  result: ICAgICAgICAxNiBRICAgICAgICAgICAgsTsA6igAoigAoigAoigAoj0QIHk= expected: ICAgICAgICAxNiBRICAgICAgICAgICAgMzMgaCAgICAgICAgICAgIDUwIHk=
> 	at compiler.intrinsics.base64.TestBase64.assertEqual(TestBase64.java:238)
> 	at compiler.intrinsics.base64.TestBase64.test0(TestBase64.java:151)
> 	at compiler.intrinsics.base64.TestBase64.main(TestBase64.java:72)

@vnkozlov Looks like I had a shift count wrong for URL encoding.  Tested it and it should now work.  Sorry for the churn.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4601


More information about the hotspot-compiler-dev mailing list