[jdk17] RFR: 8269568: JVM crashes when running VectorMask query tests
Xiaohong Gong
xgong at openjdk.java.net
Wed Jun 30 01:48:03 UTC 2021
On Tue, 29 Jun 2021 16:31:27 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> IIRC we wrote them as smoke tests because they were not intrinsic. We need to think more carefully about converting them from smoke tests.
>
Thanks for looking at this PR @PaulSandoz ! Yes, I think this need more work and more carefully to move them from the smoke tests. Maybe we can revisit them in future?
> Ideally we should convert them to kernel tests, but that is more work. Instead we can copy the generated pattern and do the following:
>
> * move the assertion outside of the loops (it will generate garbage with string concatenation)
> * assert over arrays, thereby also moving the actual scalar computation result outside the loops. The simplest approach is to create an `int[] array` of the same length as the input and write the reduced result at index `i`. Thus it's sparse.
>
> That should result in an inner loop body that is very focused on exercising the intrinsic method. It will also likely reduce the test execution times.
Agree, I will move the assertion outside of the loop first. Thanks so much!
-------------
PR: https://git.openjdk.java.net/jdk17/pull/168
More information about the hotspot-compiler-dev
mailing list