[jdk17] RFR: 8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998 [v3]

Aleksey Shipilev shade at openjdk.java.net
Wed Jun 30 17:02:48 UTC 2021


On Wed, 30 Jun 2021 16:56:30 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use filter_speculative
>
> src/hotspot/share/opto/callGenerator.cpp line 1154:
> 
>> 1152:           const Type*       sig_type = TypeOopPtr::make_from_klass(signature->accessing_klass());
>> 1153:           if (arg_type != NULL && !arg_type->higher_equal(sig_type)) {
>> 1154:             const Type* recv_type = arg_type->filter_speculative(sig_type); // keep speculative parts
> 
> No need to adjust the comment: `sig_type` doesn't have speculative part (by construction).

Right, I restored the comment incompletely.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/169


More information about the hotspot-compiler-dev mailing list