RFR: 8261730: C2 compilation fails with assert(store->find_edge(load) != -1) failed: missing precedence edge [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.java.net
Mon Mar 1 11:58:19 UTC 2021


On Mon, 1 Mar 2021 10:29:22 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> Nice analysis. Your fix looks good to me (added a minor comment).

Thanks for reviewing, Tobias! I just addressed your comment.

> src/hotspot/share/opto/gcm.cpp line 789:
> 
>> 787:         }
>> 788: #endif
>> 789:         assert((store_null_check != NULL && LCA == null_block) ||
> 
> I think you could avoid the `store_null_check != NULL` check in the assert because `LCA` is always non-null.

Done, thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2777


More information about the hotspot-compiler-dev mailing list