RFR: 8261812: C2 compilation fails with assert(!had_error) failed: bad dominance [v2]

Roland Westrelin roland at openjdk.java.net
Tue Mar 2 08:59:18 UTC 2021


On Mon, 1 Mar 2021 20:12:25 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Vladimir's review
>
> src/hotspot/share/opto/macro.cpp line 453:
> 
>> 451:         BarrierSetC2* bs = BarrierSet::barrier_set()->barrier_set_c2();
>> 452:         n = bs->step_over_gc_barrier(n);
>> 453:         if (ft == T_SHORT || ft == T_BYTE || ft == T_CHAR || ft == T_BOOLEAN) {
> 
> Use `is_subword_type(bt)` defined in `globalDefinitions.hpp`

Thanks for the review. I pushed a commit with your suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2774


More information about the hotspot-compiler-dev mailing list