RFR: 8238812: assert(false) failed: bad AD file [v2]
Tobias Hartmann
thartmann at openjdk.java.net
Wed Mar 3 14:17:42 UTC 2021
On Wed, 3 Mar 2021 10:52:37 GMT, Rahul Raghavan <rraghavan at openjdk.org> wrote:
>> src/hotspot/share/opto/ifnode.cpp line 860:
>>
>>> 858: }
>>> 859:
>>> 860: // There might be an AddINode (marked with *) with a constant increment
>>
>> Do we only need to do this for `AddNodes`? What about `SubNodes` for example?
>
> Never found a SubNode in this case. Always AddI node with integer constant as second input (this constant
> can be positive or negative values)
That's because we always convert `SubINodes` with constant second operand to `AddINodes`:
https://github.com/openjdk/jdk/blob/3d3eb5c8d31ecd80309fdcbb67cd2aeeb2037c52/src/hotspot/share/opto/subnode.cpp#L181
-------------
PR: https://git.openjdk.java.net/jdk/pull/2758
More information about the hotspot-compiler-dev
mailing list