RFR: 8262950: Restructure compiler/intrinsics/TestRotate.java for easier compilation

Eric Liu github.com+10482586+therealeliu at openjdk.java.net
Thu Mar 4 03:44:45 UTC 2021


On Wed, 3 Mar 2021 14:57:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> So, while the test is intended to test rotate intrinsics, I think it never gets there because compilation bails.

Agree. The rotate was intended to be implemented by intrinsics but finally by those dedicated nodes instead[1][2].

I was wondering if it's time to move this case out of 'intrinsics' package. Perhaps 'compiler.c2' is a more proper place .

[1] http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-July/038963.html
[2] https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-July/039048.html

-------------

PR: https://git.openjdk.java.net/jdk/pull/2811


More information about the hotspot-compiler-dev mailing list