RFR: 8238812: assert(false) failed: bad AD file [v2]

Roland Westrelin roland at openjdk.java.net
Fri Mar 5 16:02:51 UTC 2021


On Fri, 5 Mar 2021 14:25:38 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Rahul Raghavan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8238812: assert(false) failed: bad AD file
>
> Changes requested by roland (Reviewer).

This fixes the bug when the tests that need to be optimized out are next to one an another and the logic for folding comparisons can be used. It's hard to be certain that it's not possible for the 2 tests be separated by some other control flow. In that case the fix would fail.

A conservative fix would be to not use a narrow type in the CastII that tableswitch/lookupswitch switch introduces. It would be a simpler fix and a more robust one.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2758


More information about the hotspot-compiler-dev mailing list