RFR: 8261671: X86 I2L conversion can be skipped for certain masked positive values [v7]

Marcus G K Williams github.com+168222+mgkwill at openjdk.java.net
Mon Mar 8 22:03:10 UTC 2021


On Mon, 8 Mar 2021 21:08:45 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyright formatting, log description
>>   
>>   Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>
> test/hotspot/jtreg/compiler/codegen/BMI2.java line 29:
> 
>> 27:  *
>> 28:  * @run main/othervm -Xbatch -XX:-TieredCompilation -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure
>> 29:  *      -XX:CompileCommand=compileonly,compiler.codegen.BMI2$BMITests::*
> 
> It might be better to use "-XX:CompileCommand=dontinline,compiler.codegen.BMI2$BMITests::*" Then the main methods can still be compiled. As long as BMI2$BMITests method isn't inlining other BMI2$BMITests methods this is will just work just fine.

Sounds reasonable.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2590


More information about the hotspot-compiler-dev mailing list