RFR: 8261671: X86 I2L conversion can be skipped for certain masked positive values [v7]

Marcus G K Williams github.com+168222+mgkwill at openjdk.java.net
Wed Mar 10 00:30:11 UTC 2021


On Mon, 8 Mar 2021 21:13:54 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyright formatting, log description
>>   
>>   Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>
> Changes requested by neliasso (Reviewer).

Thanks for the review @neliasso. I tried both of your suggestions. 
- Rolling the test operations into a 'for' loop worked, it appears my earlier troubles w/ C2 compilation were due to another factor. 
- Using "-XX:CompileCommand=dontinline,compiler.codegen.BMI2$BMITests::*" did not allow me to manually verify the assembly code was appearing and that the test was valid. Perhaps I'm missing something. See my comment for more detail.

Thanks again for your review. Please let me know what you think and if you have other suggestions or comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2590


More information about the hotspot-compiler-dev mailing list