RFR: 8262910: Cleanup THREAD/TRAPS/naming and typing issues in ObjectMonitor and related code [v5]
Serguei Spitsyn
sspitsyn at openjdk.java.net
Wed Mar 10 02:52:12 UTC 2021
On Wed, 10 Mar 2021 02:16:17 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>>
>> - Merge branch 'master' into 8262910-sync-traps
>> - Updated request_deflate_idle_monitors as it can only be called by a JavaThread via WhiteBox API
>> - Fix typo
>> - Fixed up BiasedLocking code in ObjectSynchronizer::enter
>> - iFixed alignment in macro
>> - More pointer declaration style fixups
>> - ObjectMonitor::exit can't actually throw IMSE so replaced TRAPS with JavaThread* current
>> - Style fix: Thread * -> Thread* in type declarations
>> - Forgot to updated Graal config for JVMCI structs change
>> - 8262910: Cleanup THREAD/TRAPS/naming and typing issues in ObjectMonitor and related code
>
> Marked as reviewed by dcubed (Reviewer).
Thank you for explanations, David.
I did not insist the `deflate_idle_monitors` has to be changed just wanted to double-check if there is any need.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2802
More information about the hotspot-compiler-dev
mailing list