RFR: 8261931: IGV: quick search fails on multi-line node labels
Roberto Castañeda Lozano
rcastanedalo at openjdk.java.net
Wed Mar 10 11:30:06 UTC 2021
On Tue, 9 Mar 2021 23:08:23 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> This change makes it possible to match any field of a multi-line node label, by removing line breaks from the `label` node property that is searched on by default.
>>
>> Tested manually using different node label configurations (configurable in `Tools` -> `Options` -> `General`), with and without line breaks.
>
> LGTM
Thanks for the feedback @navyxliu!
> The reason is Figure.getWitdh() for lines. I don't think it can get appropriate width if the string contains \R.
I cannot reproduce this problem, do you have an example where a node's width is not properly adjusted?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2889
More information about the hotspot-compiler-dev
mailing list