RFR: 8261137: Optimization of Box nodes in uncommon_trap [v6]

[Wang Huang]

On Fri, 5 Mar 2021 22:42:43 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix bugs
>
> src/hotspot/share/opto/callGenerator.cpp line 573:
> 
>> 571: 
>> 572: #ifndef PRODUCT
>> 573:     if (PrintEliminateAllocations && safepoints.size() > 0) {
> 
> Strictly speaking, `PrintEliminateAllocations` is EA-specific flag.
> Not sure it has to cover `EliminateAutoBox`/`AggressiveUnboxing`.

I think it is just like  https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/macro.cpp#L1158
or we add a new option here?

> test/hotspot/jtreg/compiler/c2/TestEliminateBoxInDebugInfo.java line 49:
> 
>> 47:             "-XX:CompileCommand=compileonly,compiler/c2/TestEliminateBoxInDebugInfo$Test.foo",
>> 48:             "-XX:CompileCommand=dontinline,compiler/c2/TestEliminateBoxInDebugInfo$Test.black",
>> 49:             "-XX:+PrintEliminateAllocations",
> 
> Add `-Xbatch` to ensure the compilation is complete by the time the test finishes.

Thank you for your review. I will fix it.

> test/hotspot/jtreg/compiler/c2/TestIdentityWithEliminateBoxInDebugInfo.java line 31:
> 
>> 29:  * @library /test/lib
>> 30:  *
>> 31:  * @run main/othervm compiler.c2.TestIdentityWithEliminateBoxInDebugInfo
> 
> Same here: add `-Xbatch`.

Sure. Thank you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2401