RFR: 8262355: Support for AVX-512 opmask register allocation. [v4]

Jatin Bhateja jbhateja at openjdk.java.net
Wed Mar 10 15:57:09 UTC 2021


On Fri, 5 Mar 2021 14:15:57 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8262355: Some synthetic changes for cleanup.
>
> src/hotspot/share/opto/matcher.cpp line 995:
> 
>> 993:     idealreg2regmask[Op_RegVMask] = regmask_for_ideal_register(Op_RegVMask, ret);
>> 994:   } else {
>> 995:     idealreg2regmask[Op_RegVMask] = idealreg2regmask[Op_RegI];
> 
> How `idealreg2regmask[Op_RegVMask]` is used when `Matcher::has_predicated_vectors() == false`?

No new register pressure threshold has been introduced for predicate registers, hence just a default initialization for targets which do not support them, since its getting used in raise/lower_pressure 

> Hi Jatin,
> 
> Thanks for the work. Unfortunately, it seems that there are some conflicts (e.g. type definition) with our work at [openjdk/panama-vector#40](https://github.com/openjdk/panama-vector/pull/40). Could you please help to take a look at [openjdk/panama-vector#40](https://github.com/openjdk/panama-vector/pull/40), so that we could improve that as well and reduce the potential merge effort?
> 
> Thanks,
> Ningsheng

Hi Ningsheng,

This is the base version, changes are generic in nature and it also cleans up existing hard coded opmask register usages in X86 port.  Regarding code level naming confits, we can work over them once we land the base patch. I have taken care of your suggestions and comments.

Best Regards,
Jatin

-------------

PR: https://git.openjdk.java.net/jdk/pull/2768


More information about the hotspot-compiler-dev mailing list