RFR: 8261931: IGV: quick search fails on multi-line node labels

Thu Mar 11 08:28:06 UTC 2021

On Tue, 9 Mar 2021 09:20:57 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> This change makes it possible to match any field of a multi-line node label, by removing line breaks from the `label` node property that is searched on by default.
> 
> Tested manually using different node label configurations (configurable in `Tools` -> `Options` -> `General`), with and without line breaks.

Looks good!

Another thing that I've noticed in `Tool` -> `General`: There is no response when clicking the `Apply` button. Is it even mapped to an action? When clicking `Apply` and then `Cancel` it has not applied the changes. Maybe the button can also just be or removed. But that can be handled in another RFE.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2889