RFR: 8261931: IGV: quick search fails on multi-line node labels

Roberto Castañeda Lozano rcastanedalo at openjdk.java.net
Thu Mar 11 09:21:06 UTC 2021


On Thu, 11 Mar 2021 09:06:17 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>>> Looks good!
>> 
>> Thanks for reviewing, Christian!
>> 
>>> Another thing that I've noticed in `Tool` -> `General`: There is no response when clicking the `Apply` button. Is it even mapped to an action? When clicking `Apply` and then `Cancel` it has not applied the changes. Maybe the button can also just be or removed. But that can be handled in another RFE.
>> 
>> Right, at the moment this is just an effectless leftover from the NetBeans platform. I will make a note about it.
>
>> > Another thing that I've noticed in `Tool` -> `General`: There is no response when clicking the `Apply` button. Is it even mapped to an action? When clicking `Apply` and then `Cancel` it has not applied the changes. Maybe the button can also just be or removed. But that can be handled in another RFE.
>> 
>> Right, at the moment this is just an effectless leftover from the NetBeans platform. I will make a note about it.
> 
> Sounds good.

Remove line breaks from the 'label' property that is searched on by default.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2889


More information about the hotspot-compiler-dev mailing list