RFR: 8263248: IGV: accept graphs without node categories
Tobias Hartmann
thartmann at openjdk.java.net
Thu Mar 11 10:19:16 UTC 2021
On Wed, 10 Mar 2021 08:30:24 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
> Currently, IGV fails if the input graphs do not contain node category information (added in JDK 17). This change replaces the failing assertion with a warning message in the log file, to support using the latest IGV on graphs generated before JDK 17.
>
> Tested manually on graphs generated [from JDK 11](https://bugs.openjdk.java.net/secure/attachment/93600/from-jdk-11.zip) and [from JDK 17](https://bugs.openjdk.java.net/secure/attachment/93601/from-jdk-17.zip).
Looks good to me too and fixes the error I was getting.
-------------
Marked as reviewed by thartmann (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2909
More information about the hotspot-compiler-dev
mailing list