RFR: 8263058: Optimize vector shift with zero shift count [v2]

Eric Liu github.com+10482586+therealeliu at openjdk.java.net
Thu Mar 11 10:41:11 UTC 2021


On Thu, 11 Mar 2021 09:56:50 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Eric Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix build failure
>>   
>>   Change-Id: Id7d6f4bbb5d8dde8d1a6c5c9cd5052d64fd978a9
>
> src/hotspot/share/opto/vectornode.hpp line 524:
> 
>> 522:   ShiftVNode(Node* in1, Node* in2, const TypeVect* vt) : VectorNode(in1,in2,vt) {}
>> 523:   virtual Node* Identity(PhaseGVN* phase);
>> 524:   virtual int Opcode() const = 0;
> 
> I don't think the `Opcode` declaration is needed.

I intended to mark this class as abstract, to prevent it from being instanced.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2911


More information about the hotspot-compiler-dev mailing list