RFR: 8261137: Optimization of Box nodes in uncommon_trap [v4]
Vladimir Kozlov
kvn at openjdk.java.net
Thu Mar 11 18:16:09 UTC 2021
On Wed, 10 Mar 2021 18:36:17 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>>> @iwanowww Do you think we should add checks for EnableVectorAggressiveReboxing and EliminateAutoBox into deoptimization code or guard Vector API code and this optimization with C->do_escape_analysis()?
>>
>> The former (additional checks for EnableVectorAggressiveReboxing and EliminateAutoBox).
>> Vector box elimination is unrelated to escape analysis pass and should work irrespective of whether EA is turned on or off.
>
>> > @iwanowww Do you think we should add checks for EnableVectorAggressiveReboxing and EliminateAutoBox into deoptimization code or guard Vector API code and this optimization with C->do_escape_analysis()?
>>
>> The former (additional checks for EnableVectorAggressiveReboxing and EliminateAutoBox).
>> Vector box elimination is unrelated to escape analysis pass and should work irrespective of whether EA is turned on or off.
>
> Okay. I will do it for 8263125 fix.
I added both flags checks in deoptimizer in https://github.com/openjdk/jdk/pull/2924
@Wanghuang-Huawei you don't need to do it here.
But I am lost on the status of these changes. Do you have other updates for them? Or current 05 is final?
You found that the testing failure is not related and addressed other my and @iwanowww questions.
If 05 version is final and I already tested it, we are ready for approval.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2401
More information about the hotspot-compiler-dev
mailing list