RFR: 8263164: assert(_base >= VectorA && _base <= VectorZ) failed: Not a Vector while calling StoreVectorNode::memory_size() [v3]
Jie Fu
jiefu at openjdk.java.net
Fri Mar 12 11:44:07 UTC 2021
On Fri, 12 Mar 2021 09:22:05 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
> Why not simply cache the vector type of value being stored during `StoreVectorNode` construction and use it for subsequent queries? Most of the vector nodes already do that since `VectorNode` subclasses `TypeNode`, but `StoreVectorNode` is a `MemNode`.
>
> And that's the reason I don't understand why non-`StoreVectorNode`-related changes are needed in your patch.
>
> Nevertheless, there's another case that seems to suffer from the very same problem - `ReductionNode`.
Thanks @iwanowww for your review.
Good suggestion!
Will re-do it based on your comments.
Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2867
More information about the hotspot-compiler-dev
mailing list