RFR: 8263587: C2: JVMS not cloned when needs_clone_jvms() is true [v2]

Martin Doerr mdoerr at openjdk.java.net
Mon Mar 15 13:22:15 UTC 2021


On Mon, 15 Mar 2021 11:19:18 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup as suggested by Vladimir Ivanov.
>
> Looks good.
> 
> Cleanup idea: `CallNode::clone_jvms()` overrides differ only in the guarding condition. Extract node type dependent checks into a new helper method (`CallNode::needs_clone_jvms()`) and use it from now non-virtual `CallNode::clone_jvms()`.

Thanks for the reviews and the cleanup proposal! Please take a look at my updated version.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3009


More information about the hotspot-compiler-dev mailing list