RFR: 8262739: String inflation C2 intrinsic prevents insertion of anti-dependencies [v2]

Tobias Hartmann thartmann at openjdk.java.net
Tue Mar 16 13:00:30 UTC 2021


On Tue, 16 Mar 2021 12:57:00 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved check out of ifdef
>
> Marked as reviewed by chagedorn (Reviewer).

Thanks for the review, Christian!

> src/hotspot/share/adlc/formssel.cpp line 781:
> 
>> 779:        !strcmp(_matrule->_rChild->_opType,"RotateRight")   ||
>> 780: #if INCLUDE_SHENANDOAHGC
>> 781:        !strcmp(_matrule->_rChild->_opType,"StrInflatedCopy") ||
> 
> Should not be inside `#if INCLUDE_SHENANDOAHGC`.

Yes, good catch, thank you! (That happens when doing last-minute re-ordering ...). Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3025


More information about the hotspot-compiler-dev mailing list