RFR: 8261671: X86 I2L conversion can be skipped for certain masked positive values [v9]
Nils Eliasson
neliasso at openjdk.java.net
Tue Mar 16 18:43:10 UTC 2021
On Wed, 10 Mar 2021 17:56:25 GMT, Marcus G K Williams <github.com+168222+mgkwill at openjdk.org> wrote:
>> 8261671: X86 I2L conversion can be skipped for certain masked positive values
>>
>> For the following expression:
>> (long)(value & mask)
>> Where value is of int type and mask is constant (power of two – 1), we can directly generate bzhi instruction to zero the upper bits instead of doing an andl, followed by movslq
>>
>> Before:
>> Benchmark Mode Cnt Score Error Units
>> SkipIntToLongCast.skipMaskedSmallPositiveCast avgt 15 10.679 ± 1.496 ns/op
>>
>>
>> After:
>> Benchmark Mode Cnt Score Error Units
>> SkipIntToLongCast.skipMaskedSmallPositiveCast avgt 15 7.870 ± 0.067 ns/op
>>
>> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>
> Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:
>
> Refactor BMI2.java based on review
>
> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
My comments has been resolved and the result looks good.
-------------
Marked as reviewed by neliasso (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2590
More information about the hotspot-compiler-dev
mailing list