Integrated: 8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address()

Fei Yang fyang at openjdk.java.net
Thu Mar 18 02:29:50 UTC 2021


On Wed, 17 Mar 2021 01:34:56 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Noticed this issue when I am trying to backport: https://bugs.openjdk.java.net/browse/JDK-8263425
> 
> Around line 180 we have:
> 
>          __ add(index, LIR_OprFact::intptrConst(large_disp), tmp);
>          index = tmp;
>        } else {
>          __ move(tmp, LIR_OprFact::intptrConst(large_disp));      <========
>          __ add(tmp, index, tmp);
>          index = tmp;
>        }
> 
> This is supposed to be calculating "tmp = large_disp" but it actually does "large_disp = tmp".
> Looks like this is missed by JDK-8263425.
> Tested tier1  with -XX:TieredStopAtLevel=1 on AArch64 Linux.

This pull request has now been integrated.

Changeset: 81ba5784
Author:    Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/81ba5784
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address()

Reviewed-by: adinn

-------------

PR: https://git.openjdk.java.net/jdk/pull/3040


More information about the hotspot-compiler-dev mailing list