RFR: 8263658: Use the blessed modifier order in java.base [v2]
Alex Blewitt
github.com+76791+alblue at openjdk.java.net
Thu Mar 18 17:08:40 UTC 2021
On Thu, 18 Mar 2021 17:03:28 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> If I have other fixes for different modules, should I file PRs with the same bug number e.g. "8263658: Use the blessed modifier order in java.logging/java.desktop" or should we have separate bug numbers for them?
>
>> If I have other fixes for different modules, should I file PRs with the same bug number e.g. "8263658: Use the blessed modifier order in java.logging/java.desktop" or should we have separate bug numbers for them?
>
> Separate bug numbers is necessary. Unless you repurpose / widen this PR to include more modules.
>
> A word of advice: Avoid git rebase + force push after opening a PR for review, since it might mess up the review context. Preferably either merge in changes from main, or just keep adding commits without syncing up - the system will ensure your patch can be merged in without conflicts.
I'm happy to either widen the scope of this PR or to submit multiple but I have to rely on the kindness of strangers to create appropriate bugs in the system. On the one hand I don't want to cause a lot of noise but on the other having smaller independent commits (particularly if they hit a lot of files/modules) seems like a more sensible plan to me.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2993
More information about the hotspot-compiler-dev
mailing list