RFR: 8263776: [JVMCI] add helper to perform Java upcalls [v2]

[Tom Rodriguez]

On Thu, 18 Mar 2021 16:46:25 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Tom Rodriguez has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>> 
>>  - Review comments
>>  - 8263776: [JVMCI] add helper to perform Java upcalls
>
> src/hotspot/share/jvmci/jvmciRuntime.cpp line 488:
> 
>> 486: 
>> 487:  public:
>> 488:   ArgumentPusher(Symbol* signature, JavaCallArguments*  jca, jlong argument, bool is_static) : SignatureIterator(signature) {
> 
> `is_static` is not used.

fixed

> src/hotspot/share/jvmci/jvmciRuntime.cpp line 527:
> 
>> 525:   JavaCallArguments jca(mh->size_of_parameters());
>> 526:   ArgumentPusher jap(signature, &jca, argument, mh->is_static());
>> 527:   JavaValue result(jap.get_ret_type());
> 
> `jap.get_ret_type()` is used several times in this code. Why not cache it in local variable?

fixed

> src/hotspot/share/jvmci/jvmciRuntime.cpp line 554:
> 
>> 552:         return value->j;
>> 553:       default:
>> 554:         ShouldNotReachHere();
> 
> I would prefer to see `fatal(msg)` which prints what is unexpected type.

fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3067