RFR: 8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32 [v2]

Marcus G K Williams github.com+168222+mgkwill at openjdk.java.net
Mon Mar 22 17:49:59 UTC 2021


> Further fixes (in addition to https://github.com/openjdk/jdk/pull/3104) for issue where BzhiTestI2L.java fails on x86_32.  bzhiq instructions are only generated on x86_64.
> 
> This adds a skip to the test if `Platform.isX86()` and uses `((BmiTestCase) testCase).getTestCaseX64() && Platform.isX64()` to decide when to use `((BmiTestCase_x64) testCase).getInstrPattern_x64()` versus `((BmiTestCase) testCase).getInstrPattern()` (x86_32 version of instruction)
> 
> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>

Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:

  Fix implemented typo
  
  Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3128/files
  - new: https://git.openjdk.java.net/jdk/pull/3128/files/4c3426b1..da6891c3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3128&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3128&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3128.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3128/head:pull/3128

PR: https://git.openjdk.java.net/jdk/pull/3128


More information about the hotspot-compiler-dev mailing list