RFR: 8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32 [v2]
Vladimir Kozlov
kvn at openjdk.java.net
Mon Mar 22 17:50:00 UTC 2021
On Mon, 22 Mar 2021 17:47:11 GMT, Marcus G K Williams <github.com+168222+mgkwill at openjdk.org> wrote:
>> Further fixes (in addition to https://github.com/openjdk/jdk/pull/3104) for issue where BzhiTestI2L.java fails on x86_32. bzhiq instructions are only generated on x86_64.
>>
>> This adds a skip to the test if `Platform.isX86()` and uses `((BmiTestCase) testCase).getTestCaseX64() && Platform.isX64()` to decide when to use `((BmiTestCase_x64) testCase).getInstrPattern_x64()` versus `((BmiTestCase) testCase).getInstrPattern()` (x86_32 version of instruction)
>>
>> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>
> Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix implemented typo
>
> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
@mgkwill do you have plan to implement this optimization on 32-bit x86?
test/hotspot/jtreg/compiler/intrinsics/bmi/TestBzhiI2L.java line 47:
> 45: public static void main(String args[]) throws Throwable {
> 46: if (Platform.isX86()) {
> 47: System.out.println("INFO: Bzhiq not implimented for x86_32, test SKIPPED" );
typo: `implimented`
should be `implemented`
-------------
PR: https://git.openjdk.java.net/jdk/pull/3128
More information about the hotspot-compiler-dev
mailing list