RFR: 8263358: Update java.lang to use instanceof pattern variable [v8]

Daniel Fuchs dfuchs at openjdk.java.net
Mon Mar 22 17:52:43 UTC 2021


On Mon, 22 Mar 2021 17:47:10 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:

>> Hi,
>> 
>> Could someone please review my code for updating the code in the `java.lang` package to make use of the `instanceof` pattern variable?
>> 
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - 8263358: Moved check for declaringClass to after lineNumber
>  - Merge remote-tracking branch 'origin/master' into JDK-8263358
>  - 8263358: Added wildcard to instanceof check; reordered primitive equality check
>  - Merge remote-tracking branch 'origin/master' into JDK-8263358
>  - 8263358: Refactored missed equals method
>  - Merge remote-tracking branch 'origin/master' into JDK-8263358
>  - 8263358: Refactored equals methods
>  - Merge remote-tracking branch 'origin/master' into JDK-8263358
>  - 8263358: Update java.lang to use instanceof pattern variable

The new changes look good to me.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2913


More information about the hotspot-compiler-dev mailing list