RFR: 8167015: compiler/codecache/jmx/PoolsIndependenceTest.java timeout [v2]

Tobias Hartmann thartmann at openjdk.java.net
Tue Mar 23 06:54:49 UTC 2021


On Wed, 17 Mar 2021 19:06:18 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

>> Fixed some issues in the test:
>> 
>> 1. Replaced obvious mistake with event duration equal to `beginTimestamp - lastEventTimestamp` (giving negative value)
>> 2. Using timeouts to address the problem with notification not being sent due to code cache usage never hitting the limit. Possible explanations:
>>     Code cache was cleaned just after setting the limit;
>>     CodeCacheUtils silently failed the blob allocation, causing the notification to never get fired
>> 3. Provided some additional info in both the test log, and failure messages.
>
> Evgeny Nikitin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8167015/public
>  - Un-problemlist the PoolsIndependenceTest
>  - 8167015: compiler/codecache/jmx/PoolsIndependenceTest.java timeout

Looks good to me too.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3033


More information about the hotspot-compiler-dev mailing list