RFR: 8259822: [PPC64] Support the prefixed instruction format added in POWER10 [v3]

Martin Doerr mdoerr at openjdk.java.net
Tue Mar 23 16:05:48 UTC 2021


On Mon, 1 Feb 2021 18:30:48 GMT, Corey Ashford <cashford at openjdk.org> wrote:

>> Kazunori Ogata has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update (2nd round) based on review comments
>
> src/hotspot/cpu/ppc/assembler_ppc.inline.hpp line 149:
> 
>> 147: inline void Assembler::paddi(  Register d, Register a, long si34, bool r = false) {
>> 148:   assert(a != R0 || r, "r0 not allowed, unless R is set (CIA relative)");
>> 149:   paddi_r0ok( d, a, si34, r);
> 
> The space after the ( isn't needed here, since it's not aligning with a similar call above or below.

Right, please remove extra spaces.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2095


More information about the hotspot-compiler-dev mailing list