RFR: 8263769: simplify PhaseMacroExpand::extract_call_projections() [v2]

Xin Liu xliu at openjdk.java.net
Tue Mar 23 22:40:40 UTC 2021


On Tue, 23 Mar 2021 13:46:01 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8263769: simplify PhaseMacroExpand::extract_call_projections()
>>   
>>   replace individual call projects with a POD object _call_projects.
>>   replace PhaseMacroExpand::extract_call_projections() with CallNode::extract_projections().
>
> src/hotspot/share/opto/macro.hpp line 85:
> 
>> 83: private:
>> 84:   // projections extracted from a call node
>> 85:   CallProjections _call_projects;
> 
> Please, use either `_call_projs` or `_call_projections`.  (Or even drop `_call_` prefix.)

change to _callprojs because I found other places use callprojs.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3105


More information about the hotspot-compiler-dev mailing list