RFR: 8261137: Optimization of Box nodes in uncommon_trap [v9]

Wang Huang whuang at openjdk.java.net
Wed Mar 24 02:54:51 UTC 2021


On Tue, 23 Mar 2021 16:57:38 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Wang Huang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8261137
>>  - refactor
>>  - refactor some codes
>>  - fix bugs
>>  - add debuginfo optimization
>>  - delete useless line
>>  - fix some bugs
>>  - refactor codes
>>  - 8261137: Optimization of Box nodes in uncommon_trap
>
> test/hotspot/jtreg/compiler/c2/TestEliminateBoxInDebugInfo.java line 1:
> 
>> 1: /*
> 
> The test should be in `compiler/eliminateAutobox` directory. `compiler/c2` is collection of old unsorted tests.

OK. I will do that.

> test/hotspot/jtreg/compiler/c2/TestEliminateBoxInDebugInfo.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 8261137
>> 27:  * @requires vm.debug == true & vm.flavor == "server"
> 
> Exclude Graal because it would not have output you expect. Instead of checking for "server" check for C2:
> `@requires vm.debug == true & vm.compiler2.enabled`

OK. I will do that ASAP.

> test/hotspot/jtreg/compiler/c2/TestIdentityWithEliminateBoxInDebugInfo.java line 1:
> 
>> 1: /*
> 
> The test should be in compiler/eliminateAutobox directory.

OK. Thank you for your review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2401


More information about the hotspot-compiler-dev mailing list