RFR: 8263582: WB_IsMethodCompilable ignores compiler directives [v2]

Christian Hagedorn chagedorn at openjdk.java.net
Thu Mar 25 15:41:46 UTC 2021


On Thu, 25 Mar 2021 15:33:18 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix typo
>
> Marked as reviewed by iveresov (Reviewer).

Thanks Igor for your review!

> test/hotspot/jtreg/compiler/whitebox/TestMethodCompilableCompilerDirectives.java line 64:
> 
>> 62:     // to prevent a compilation is evaluated lazily and is only applied when a compilation for m is attempted.
>> 63:     // Another problem is that Method::is_not_compilable() only returns true for CompLevel_any if C1 AND C2 cannot compile it.
>> 64:     // This means that a compilation of m must have been attempted for C1 and C2 before WB::isMethodCompilable(m, CompLevl_any) will
> 
> A typo "CompLevl_any" -> "CompLevel_any".

Thanks, fixed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3195


More information about the hotspot-compiler-dev mailing list