RFR: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node"

[Tobias Hartmann]

On Sat, 27 Mar 2021 02:49:34 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> LoadStore node misses Value() method which checks for Top inputs. As result dead data IR subgraph was not removed. Control subgraph is not eliminated because of complicated loop. 
> 
> The fix is to add missing Value() method.
> Small refactoring in StoreCMNode::Value() because StoreNode::Value() already has checks for TOP edges.
> Added check to SCMemProjNode::Value() which led to changes in GraphKit::compress_string() where call to transform() was missing.
> Dumping additional info for asserts and code style fixes in macro.cpp.
> 
> Tested tier1-4 and xcomp.

Looks good to me but could you please update the code style of the lines you've touched? For example:
`const Type *t = phase->type( in(MemNode::Memory) );` -> `const Type* t = phase->type(in(MemNode::Memory));`

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3226