RFR: 8262093: java/util/concurrent/tck/JSR166TestCase.java failed "assert(false) failed: unexpected node" [v2]

[Vladimir Kozlov]

> LoadStore node misses Value() method which checks for Top inputs. As result dead data IR subgraph was not removed. Control subgraph is not eliminated because of complicated loop. 
> 
> The fix is to add missing Value() method.
> Small refactoring in StoreCMNode::Value() because StoreNode::Value() already has checks for TOP edges.
> Added check to SCMemProjNode::Value() which led to changes in GraphKit::compress_string() where call to transform() was missing.
> Dumping additional info for asserts and code style fixes in macro.cpp.
> 
> Tested tier1-4 and xcomp.

Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:

  Additional code style fixes

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3226/files
  - new: https://git.openjdk.java.net/jdk/pull/3226/files/36a00598..844ec6f5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3226&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3226&range=00-01

  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3226.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3226/head:pull/3226

PR: https://git.openjdk.java.net/jdk/pull/3226